fix(styles): menu command with & without icons aren't aligned #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a `$slick-menu-icon-min-width` to align icon containers so that they are always aligned with and without icons
Codecov Report
@@ Coverage Diff @@
## master #1180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 245 245
Lines 17253 17253
Branches 6233 6233
=========================================
Hits 17253 17253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$slick-menu-icon-min-widthSASS/CSS variable to align icon containers so that they are always aligned with and without icons. The issue only showed when the user has both with & without command icon as shown below. Adding amin-widthhelps so that the container, which usesflexdoesn't shrink the icon span when no icon is provided