Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for grid inside Shadow DOM #1166

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 31, 2023

TODOs

  • requires new SlickGrid v4.x

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #1166 (0a6a902) into master (bd132c5) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17166     17225   +59     
  Branches      6196      6230   +34     
=========================================
+ Hits         17166     17225   +59     
Files Coverage Δ
...es/common/src/extensions/slickDraggableGrouping.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickGridMenu.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

@ghiscoding ghiscoding changed the title WIP - feat: add support for grid inside Shadow DOM feat: add support for grid inside Shadow DOM Nov 1, 2023
@ghiscoding ghiscoding merged commit f7b8c46 into master Nov 1, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/shadow-dom branch November 1, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant