Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): clicking Menu close button should only close current menu #1160

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 29, 2023

  • prior to this PR, clicking a close button would close all type of menus but in theory it should only close the targeted Menu instead of all menus. This could caused issues and trigger unexpected events like onGridMenuMenuClose even if the Grid Menu was in fact closed

- prior to this PR, clicking a close button would close all type of menus but in theory it should only close the targeted Menu instead of all menus
@codecov
Copy link

codecov bot commented Oct 29, 2023

Codecov Report

Merging #1160 (01dea9e) into master (634441c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17147     17147           
  Branches      6186      6186           
=========================================
  Hits         17147     17147           
Files Coverage Δ
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/slickColumnPicker.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit b524ef1 into master Oct 29, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/close-button branch October 29, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant