Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sub-menu(s) to HeaderMenu plugin #1158

Merged
merged 5 commits into from
Oct 29, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 28, 2023

  • currently only works by click event on sub-menus, the mouseover will be implemented in a future PR

TODOs

  • add full unit test coverage
  • add Cypress E2E tests
  • it might be nice to add auto-align top/bottom especially for sub-menus

image

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #1158 (637364c) into master (8999297) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          245       245           
  Lines        17075     17145   +70     
  Branches      6151      6182   +31     
=========================================
+ Hits         17075     17145   +70     
Files Coverage Δ
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickGridMenu.ts 100.00% <ø> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit eeab42e into master Oct 29, 2023
5 checks passed
@ghiscoding ghiscoding deleted the feat/header-menu-sub-menus branch October 29, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant