Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): make sure destroy is a function before calling it #1148

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@1fd2739). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master     #1148   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?       245           
  Lines             ?     17003           
  Branches          ?      6114           
==========================================
  Hits              ?     17003           
  Misses            ?         0           
  Partials          ?         0           
Files Coverage Δ
packages/common/src/editors/autocompleterEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/autocompleterFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit dba9606 into master Oct 24, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/destroy-is-function branch October 24, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants