Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copying multiple times only kept last undo CellExternalCopyManager #1075

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

ghiscoding
Copy link
Owner

  • fix an issue where copying and pasting to multiple area only kept the last undo and reapplied it over and over and the cause was because the clipCommand was global to the class so it only kept the last undo, the fix is to make sure the clipCommand variable is local to the execution handler instead

- fix an issue where copying and pasting to multiple area only kept the last undo and reapplied it over and over and the cause was because the clipCommand was global to the class so it only kept the last undo, the fix is to make sure the clipCommand variable is local to the execution handler instead
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #1075 (4b72929) into master (07efeb6) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1075   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16564     16562    -2     
  Branches      5933      5933           
=========================================
- Hits         16564     16562    -2     
Files Changed Coverage Δ
...mon/src/extensions/slickCellExternalCopyManager.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit e3beee2 into master Aug 17, 2023
@ghiscoding ghiscoding deleted the bugfix/cell-external-copy-buffer-undo-redo branch August 17, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant