Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): Select Filter/Editor regular text shouldn't be html encoded #1011

Merged
merged 8 commits into from
Jun 28, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 28, 2023

  • fix a regression bug introduced by PR feat!: drop jQuery requirement & use multiple-select-vanilla dependency #976 when migrating from ms-select to ms-select-vanilla, the text should be encode only when renderHtmlEnabled is enabled and not encoded when it's the flag is disabled, basically the html encode was set on the wrong condition
  • in other words and in a shorter description, we should only html encode text when enableRenderHtml is enabled
  • regression commit ref
  • there was an issue in both libs to fix this regression which came from v3.0 when we removed jQuery and start using the new ms-select-vanilla lib
    • Multiple-Select-Vanilla PR 86
    • and this PR here for Slickgrid-Universal

Regression bug

image

Before Fix

image

After Fix

image

when renderOptionLabelAsHtml is disabled

image

when renderOptionLabelAsHtml is enabled

image

- fix a regression bug introduced by PR #976 when migrating from ms-select to ms-select-vanilla, the text should be encode only when `renderHtmlEnabled` is enabled and not encoded when it's the flag is disabled, basically the html encode was set on the wrong condition
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #1011 (1603281) into master (fa81d7a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16556     16556           
  Branches      5928      5929    +1     
=========================================
  Hits         16556     16556           
Impacted Files Coverage Δ
packages/common/src/filters/selectFilter.ts 100.00% <100.00%> (ø)
packages/common/src/services/domUtilities.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit c203a2c into master Jun 28, 2023
@ghiscoding ghiscoding deleted the bugfix/ms-select-vanilla-html-encode branch June 28, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant