-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services): add registerServices in Grid Options #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the "registerServices" can accept an array of Services to register, this could be used by the user when he wants to load External Services like ExcelExportService, FileExportService, ... - also add DataView interface
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 94.71% 94.77% +0.07%
==========================================
Files 172 171 -1
Lines 8510 8554 +44
Branches 2880 2817 -63
==========================================
+ Hits 8059 8106 +47
+ Misses 451 448 -3
Continue to review full report at Codecov.
|
- remove Translater Service from the Export Services constructor
- use the pubSub service from the shared service passed in the init() method
- also add missing SlickGrid/DataView types everywhere
ghiscoding
changed the title
WIP - feat(services): add registerServices in Grid Options
feat(services): add registerServices in Grid Options
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "registerServices" can accept an array of Services to register, this could be used by the user when he wants to load External Services like ExcelExportService, FileExportService, ...
also add DataView and SlickGrid interfaces
See Migration for new usage
TODO
registeringExternalServices
method to handle Export Services