New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use setTimeout/setInterval from window object with correct TS type #397

Merged

ghiscoding merged 3 commits into master from bugfix/settimeout-types

Aug 17, 2024

Owner

ghiscoding commented Aug 17, 2024 •

edited

Loading

newest version of @types/node and TypeScript is sometime throwing some errors
I thought that we should always use setTimeout directly but its type is NodeJS.timeout type, however we should be using window.setTimeout with a return type of number instead since our project is always a Browser App hence the use of the window object


          fix: use setTimeout/setInterval from window object with correct TS type

7fc3800

stackblitz bot commented Aug 17, 2024

Run & review this pull request in StackBlitz Codeflow.

ghiscoding added 2 commits

August 17, 2024 11:47


          chore: update Slickgrid-Universal to latest

5645d24


          chore: update lock file

47d27a6

ghiscoding merged commit badb990 into master

4 checks passed

ghiscoding deleted the bugfix/settimeout-types branch

August 17, 2024 16:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet