From 64e895b1aecefa9192a80711dd421fe4a5f0797c Mon Sep 17 00:00:00 2001
From: "Ghislain B." <gbeaulac@gmail.com>
Date: Sat, 5 Oct 2024 01:56:37 -0400
Subject: [PATCH] fix: avoid barrel files, keep only 1 entry file (#304)

---
 .../multiple-select-vanilla/build-prod.mjs    |  3 ++
 .../src/MultipleSelectInstance.ts             | 10 +++--
 .../multiple-select-vanilla/src/constants.ts  |  3 +-
 packages/multiple-select-vanilla/src/index.ts | 42 ++++++++++++++++---
 .../src/interfaces/index.ts                   |  3 --
 .../src/locales/multiple-select-cz-CS.ts      |  2 +-
 .../src/locales/multiple-select-da-DK.ts      |  2 +-
 .../src/locales/multiple-select-de-DE.ts      |  2 +-
 .../src/locales/multiple-select-en-US.ts      |  2 +-
 .../src/locales/multiple-select-es-ES.ts      |  2 +-
 .../src/locales/multiple-select-fr-FR.ts      |  2 +-
 .../src/locales/multiple-select-hu-HU.ts      |  2 +-
 .../src/locales/multiple-select-it-IT.ts      |  2 +-
 .../src/locales/multiple-select-ja-JP.ts      |  2 +-
 .../src/locales/multiple-select-pt-BR.ts      |  2 +-
 .../src/locales/multiple-select-ru-RU.ts      |  2 +-
 .../src/locales/multiple-select-vi-VN.ts      |  2 +-
 .../src/locales/multiple-select-zh-CN.ts      |  2 +-
 .../src/locales/multiple-select-zh-TW.ts      |  2 +-
 .../src/{interfaces => models}/interfaces.ts  |  0
 .../locale.interface.ts                       |  0
 .../multipleSelectOption.interface.ts         |  0
 .../src/multiple-select.ts                    |  4 +-
 .../src/services/index.ts                     |  2 -
 .../src/services/virtual-scroll.ts            |  4 +-
 .../src/utils/domUtils.ts                     |  2 +-
 .../src/utils/index.ts                        |  2 -
 .../multiple-select-vanilla/tsup.config.ts    | 28 ++++++-------
 28 files changed, 80 insertions(+), 51 deletions(-)
 delete mode 100644 packages/multiple-select-vanilla/src/interfaces/index.ts
 rename packages/multiple-select-vanilla/src/{interfaces => models}/interfaces.ts (100%)
 rename packages/multiple-select-vanilla/src/{interfaces => models}/locale.interface.ts (100%)
 rename packages/multiple-select-vanilla/src/{interfaces => models}/multipleSelectOption.interface.ts (100%)
 delete mode 100644 packages/multiple-select-vanilla/src/services/index.ts
 delete mode 100644 packages/multiple-select-vanilla/src/utils/index.ts

diff --git a/packages/multiple-select-vanilla/build-prod.mjs b/packages/multiple-select-vanilla/build-prod.mjs
index e88edcff6..cccecbc7f 100644
--- a/packages/multiple-select-vanilla/build-prod.mjs
+++ b/packages/multiple-select-vanilla/build-prod.mjs
@@ -37,13 +37,16 @@ for (const format of buildFormats) {
     outfile: `dist/locales/multiple-select-all-locales.${extension}`,
   });
 
+  // - let's use TSUP to get valid hybrid (CJS/ESM) approach with are-the-types-wrong, however keep the rest of the build
   // finally, create a regular bundle as a standalone which will be accessible as MultipleSelect from the global window object
   // this file is basically a legacy alternative to import via a <script> tag
+  /*
   runBuild({
     format,
     globalName: 'MultipleSelect',
     outfile: `dist/browser/multiple-select.${extension}`,
   });
+  */
 }
 
 function runBuild(options) {
diff --git a/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts b/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
index 84198d58f..9ee519fa2 100644
--- a/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
+++ b/packages/multiple-select-vanilla/src/MultipleSelectInstance.ts
@@ -2,10 +2,12 @@
  * @author zhixin wen <wenzhixin2010@gmail.com>
  */
 import Constants from './constants';
-import type { HtmlStruct, MultipleSelectLocales, OptGroupRowData, OptionDataObject, OptionRowData } from './interfaces';
-import type { CloseReason, MultipleSelectOption } from './interfaces/multipleSelectOption.interface';
-import { BindingEventService, VirtualScroll } from './services';
-import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils';
+import type { HtmlStruct, OptGroupRowData, OptionDataObject, OptionRowData } from './models/interfaces';
+import type { MultipleSelectLocales } from './models/locale.interface';
+import type { CloseReason, MultipleSelectOption } from './models/multipleSelectOption.interface';
+import { BindingEventService } from './services/binding-event.service';
+import { VirtualScroll } from './services/virtual-scroll';
+import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils/utils';
 import {
   calculateAvailableSpace,
   classNameToList,
diff --git a/packages/multiple-select-vanilla/src/constants.ts b/packages/multiple-select-vanilla/src/constants.ts
index b1d5817a1..9f4f7779f 100644
--- a/packages/multiple-select-vanilla/src/constants.ts
+++ b/packages/multiple-select-vanilla/src/constants.ts
@@ -1,4 +1,5 @@
-import type { LabelFilter, MultipleSelectOption, TextFilter } from './interfaces';
+import type { LabelFilter, TextFilter } from './models/interfaces';
+import type { MultipleSelectOption } from './models/multipleSelectOption.interface';
 import English from './locales/multiple-select-en-US';
 
 const BLOCK_ROWS = 50;
diff --git a/packages/multiple-select-vanilla/src/index.ts b/packages/multiple-select-vanilla/src/index.ts
index be94cee88..551e973c8 100644
--- a/packages/multiple-select-vanilla/src/index.ts
+++ b/packages/multiple-select-vanilla/src/index.ts
@@ -1,6 +1,36 @@
-export * from './services';
-export * from './constants';
-export * from './interfaces';
-export * from './utils';
-export * from './multiple-select';
-export * from './MultipleSelectInstance';
+export type * from './models/interfaces';
+export type * from './models/locale.interface';
+export type * from './models/multipleSelectOption.interface';
+export { BindingEventService, type ElementEventListener } from './services/binding-event.service';
+export { VirtualScroll } from './services/virtual-scroll';
+export {
+  type HtmlElementPosition,
+  calculateAvailableSpace,
+  classNameToList,
+  convertItemRowToHtml,
+  createDomElement,
+  createDomStructure,
+  emptyElement,
+  findParent,
+  getElementOffset,
+  getElementSize,
+  insertAfter,
+  omitProp,
+  toggleElement,
+  toggleElementClass,
+  windowScrollPosition,
+} from './utils/domUtils';
+export {
+  compareObjects,
+  deepCopy,
+  findByParam,
+  isDefined,
+  objectRemoveEmptyProps,
+  removeDiacritics,
+  removeUndefined,
+  setDataKeys,
+  stripScripts,
+  toCamelCase,
+} from './utils/utils';
+export { multipleSelect } from './multiple-select';
+export { MultipleSelectInstance } from './MultipleSelectInstance';
diff --git a/packages/multiple-select-vanilla/src/interfaces/index.ts b/packages/multiple-select-vanilla/src/interfaces/index.ts
deleted file mode 100644
index c6187e1c0..000000000
--- a/packages/multiple-select-vanilla/src/interfaces/index.ts
+++ /dev/null
@@ -1,3 +0,0 @@
-export * from './interfaces';
-export * from './locale.interface';
-export * from './multipleSelectOption.interface';
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts
index ea8487494..e8f6f1c08 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts
index c61173484..f6536f7a9 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts
index f1936485b..d0fee62fe 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts
index 43f7477bc..25e523ddd 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts
index 6a80fd090..a6d26c2e8 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts
index 12d4ade9b..da95c8f28 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-fr-FR.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts
index d86a3502b..124e6eb81 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-hu-HU.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts
index ad7b11270..028abb4b6 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-it-IT.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts
index 8c25bfd0f..3863e8d15 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-ja-JP.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts
index 091fe21a1..e4a2e8afb 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-pt-BR.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts
index 5f0d241b8..304cea9f8 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-ru-RU.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts
index fce5d5c99..69876c6c5 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-vi-VN.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts
index 53fda3297..c9eb0732d 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-CN.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts
index d60f16431..be09c646f 100644
--- a/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts
+++ b/packages/multiple-select-vanilla/src/locales/multiple-select-zh-TW.ts
@@ -4,7 +4,7 @@
  */
 
 import type { MultipleSelectInstance } from '../MultipleSelectInstance';
-import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
+import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
 
 const ms =
   typeof window !== 'undefined' && window.multipleSelect !== undefined
diff --git a/packages/multiple-select-vanilla/src/interfaces/interfaces.ts b/packages/multiple-select-vanilla/src/models/interfaces.ts
similarity index 100%
rename from packages/multiple-select-vanilla/src/interfaces/interfaces.ts
rename to packages/multiple-select-vanilla/src/models/interfaces.ts
diff --git a/packages/multiple-select-vanilla/src/interfaces/locale.interface.ts b/packages/multiple-select-vanilla/src/models/locale.interface.ts
similarity index 100%
rename from packages/multiple-select-vanilla/src/interfaces/locale.interface.ts
rename to packages/multiple-select-vanilla/src/models/locale.interface.ts
diff --git a/packages/multiple-select-vanilla/src/interfaces/multipleSelectOption.interface.ts b/packages/multiple-select-vanilla/src/models/multipleSelectOption.interface.ts
similarity index 100%
rename from packages/multiple-select-vanilla/src/interfaces/multipleSelectOption.interface.ts
rename to packages/multiple-select-vanilla/src/models/multipleSelectOption.interface.ts
diff --git a/packages/multiple-select-vanilla/src/multiple-select.ts b/packages/multiple-select-vanilla/src/multiple-select.ts
index 66d4916ec..3b7f2a143 100644
--- a/packages/multiple-select-vanilla/src/multiple-select.ts
+++ b/packages/multiple-select-vanilla/src/multiple-select.ts
@@ -5,8 +5,8 @@
 
 import { MultipleSelectInstance } from './MultipleSelectInstance';
 import Constants from './constants';
-import type { MultipleSelectLocales } from './interfaces';
-import type { MultipleSelectOption } from './interfaces/multipleSelectOption.interface';
+import type { MultipleSelectLocales } from './models/locale.interface';
+import type { MultipleSelectOption } from './models/multipleSelectOption.interface';
 import English from './locales/multiple-select-en-US';
 
 /**
diff --git a/packages/multiple-select-vanilla/src/services/index.ts b/packages/multiple-select-vanilla/src/services/index.ts
deleted file mode 100644
index 592f314f4..000000000
--- a/packages/multiple-select-vanilla/src/services/index.ts
+++ /dev/null
@@ -1,2 +0,0 @@
-export * from './binding-event.service';
-export * from './virtual-scroll';
diff --git a/packages/multiple-select-vanilla/src/services/virtual-scroll.ts b/packages/multiple-select-vanilla/src/services/virtual-scroll.ts
index b8b30a9b5..1ccf76a74 100644
--- a/packages/multiple-select-vanilla/src/services/virtual-scroll.ts
+++ b/packages/multiple-select-vanilla/src/services/virtual-scroll.ts
@@ -1,6 +1,6 @@
 import Constants from '../constants';
-import type { HtmlStruct, VirtualCache, VirtualScrollOption } from '../interfaces';
-import { convertItemRowToHtml, emptyElement } from '../utils';
+import type { HtmlStruct, VirtualCache, VirtualScrollOption } from '../models/interfaces';
+import { convertItemRowToHtml, emptyElement } from '../utils/domUtils';
 
 export class VirtualScroll {
   protected clusterRows?: number;
diff --git a/packages/multiple-select-vanilla/src/utils/domUtils.ts b/packages/multiple-select-vanilla/src/utils/domUtils.ts
index 591a43741..e645df222 100644
--- a/packages/multiple-select-vanilla/src/utils/domUtils.ts
+++ b/packages/multiple-select-vanilla/src/utils/domUtils.ts
@@ -1,4 +1,4 @@
-import type { HtmlStruct, InferDOMType } from '../interfaces';
+import type { HtmlStruct, InferDOMType } from '../models/interfaces';
 import { objectRemoveEmptyProps } from './utils';
 
 export interface HtmlElementPosition {
diff --git a/packages/multiple-select-vanilla/src/utils/index.ts b/packages/multiple-select-vanilla/src/utils/index.ts
deleted file mode 100644
index 7e1f1090f..000000000
--- a/packages/multiple-select-vanilla/src/utils/index.ts
+++ /dev/null
@@ -1,2 +0,0 @@
-export * from './domUtils';
-export * from './utils';
diff --git a/packages/multiple-select-vanilla/tsup.config.ts b/packages/multiple-select-vanilla/tsup.config.ts
index cfbb8adef..b2b3b2006 100644
--- a/packages/multiple-select-vanilla/tsup.config.ts
+++ b/packages/multiple-select-vanilla/tsup.config.ts
@@ -3,7 +3,7 @@ import { defineConfig } from 'tsup';
 export default defineConfig(options => [
   // for bundlers like vite, rollup, esbuild, webpack etc
   {
-    entry: ['src/**.ts'],
+    entry: ['src/index.ts'],
     format: ['esm'],
     splitting: false,
     sourcemap: true,
@@ -27,17 +27,17 @@ export default defineConfig(options => [
   },
 
   // IIFE bundle js for cdn (window object for legacy <script>)
-  // {
-  //   entry: {
-  //     'multiple-select': 'src/index.ts',
-  //   },
-  //   format: ['iife'],
-  //   globalName: 'MultipleSelect',
-  //   splitting: false,
-  //   sourcemap: true,
-  //   clean: true,
-  //   outExtension: ({ format }) => ({
-  //     js: '.iife.js',
-  //   }),
-  // },
+  {
+    entry: {
+      'browser/multiple-select': 'src/index.ts',
+    },
+    format: ['iife'],
+    globalName: 'MultipleSelect',
+    splitting: false,
+    sourcemap: true,
+    // clean: true,
+    outExtension: ({ format }) => ({
+      js: '.iife.js',
+    }),
+  },
 ]);