fix(grid): gridHeight & gridWidth not set, closes #35 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmzagorski
reviewed
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jmzagorski
I would like like a review on this, grid height and width fix. I found this good article on
css.bindand I switched to that. I also found why I was resizing the grid at later point withgridHeightandgridWidth, it was because of the Pagination component that I use with Backend Service, it was taking 100% width of the screen instead of the grid size, unless I resized it. I found that if I put the width on the grid container, then set the grid towidth: 100%, like it is shown in the SlickGrid example, that fixes my issue and the pagination still have a width 100%.So it all seems to work for me now, but I would really like if you could take 5-10min to review and possibly test it.