Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: redraw all open row details whenever the grid is re-rendered" #1276

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 19, 2024

Reverts #1269

  • So it turns out that using the grid.onRendered event is not ideal because this event is actually called way too often (it's called even when scrolling up/down) and this makes it worst on the perf side because we should only re-render the Row Detail when it comes back into the view (i.e. scroll to the bottom of the grid and then scrolling back to top, we should re-render at that time only, however with the scroll it was re-rendering a lot of times and this is bad).... So it's better to revert previous PR and instead use the other 2 events that I proposed earlier in another PR.

Copy link

stackblitz bot commented Oct 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@9e9c9b9). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1276   +/-   ##
=========================================
  Coverage          ?   21.24%           
=========================================
  Files             ?        8           
  Lines             ?      942           
  Branches          ?      322           
=========================================
  Hits              ?      200           
  Misses            ?      742           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 8527bb2 into master Oct 19, 2024
4 checks passed
@ghiscoding ghiscoding deleted the revert-1269-bugfix/row-detail-redraw branch October 19, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant