fix: register RowDetail and dispose of it only once #1253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was because both the
externalResources
&extensionList
are arrays and to make it easier, they both loop through their arrays when it's time to dispose (destroy) of them. However theRowDetailService
was added to both arrays which was disposing of it twice instead of once. This PR fixes this by keeping RowDetail in theextensionList
but without adding it to theexternalResources
array. The other thing to note is that it's better to keep it inextensionList
since I already had code in place to get the RowDetail instance from that list as per this Example 21 codeaurelia-slickgrid/packages/demo/src/examples/slickgrid/example19.ts
Lines 43 to 51 in c066730