Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use setTimeout/setInterval from window object with correct TS type #1252

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 17, 2024

  • newest version of @types/node and TypeScript is sometime throwing some errors
  • I thought that we should always use setTimeout directly but its type is NodeJS.timeout type, however we should be using window.setTimeout with a return type of number instead since our project is always a Browser App hence the use of the window object

Copy link

stackblitz bot commented Aug 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 21.66%. Comparing base (ea30cf1) to head (59b6c28).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   21.56%   21.66%   +0.10%     
==========================================
  Files           8        8              
  Lines         937      933       -4     
  Branches      348      323      -25     
==========================================
  Hits          202      202              
+ Misses        735      731       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit f272174 into master Aug 17, 2024
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/settimeout-types branch August 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant