Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional Top-Header for Draggable Grouping & Header Grouping #1219

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 5, 2024

  • prior to this PR, we could not use Draggable Grouping & Header Grouping because both features were using the pre-header and it would have conflict, now to avoid this I am adding an extra Top-Header that will show over all header and pre-header.
  • NOTE: Draggable Grouping can now be displayed in either the new Top-Header OR the Pre-Header. However, the users who do want to use both features will need to explicitely enable both top/pre headers.
  • I was getting a little out of ideas to get a name (since "pre" is already taken), so I decided to go with Top-Header which is completely on the top and even before the pre-header.
  • Another note is that this new Top-Header is not following the frozen columns (like header & pre-header do) and is rather always the same width as the grid. I purposely did not want this top-header to follow the grid frozen columns because I wanted a simpler header and also because I expect this to be mostly (and only) be used by the Draggable Grouping.

brave_exnFdfLkAn

Copy link

stackblitz bot commented Jun 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding added the requires Universal change/release code change must first be implement in Slickgrid-Universal label Jun 5, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.37%. Comparing base (c8122e7) to head (377a484).

Files Patch % Lines
...slickgrid/src/custom-elements/aurelia-slickgrid.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
- Coverage   22.42%   22.37%   -0.04%     
==========================================
  Files           8        8              
  Lines         901      903       +2     
  Branches      330      310      -20     
==========================================
  Hits          202      202              
- Misses        699      701       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 3e555f5 into master Jun 8, 2024
5 of 6 checks passed
@ghiscoding ghiscoding deleted the feat/top-header branch June 8, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires Universal change/release code change must first be implement in Slickgrid-Universal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant