fix: spreading 2 grids options causes duplicate ext resources #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- regression fix for version 4.x branch - partially rolls back PR #1118 because that caused a regression that was identified by a user of Angular-Slickgrid in which defining a global external resource for ExcelExport no longer worked. - this PR also fixes duplicatation of external resources when having multiple grid on the same page and spreading grid options of another grid (e.g.: `{ ...this.gridOptions1, sortable: false }`)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## version6 #1127 +/- ##
===========================================
Coverage ? 99.90%
===========================================
Files ? 9
Lines ? 938
Branches ? 341
===========================================
Hits ? 937
Misses ? 1
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ ...this.gridOptions1, sortable: false })