Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resizer): remove redundant bindAutoResizeDataGrid call #839

Merged

Conversation

jr01
Copy link
Collaborator

@jr01 jr01 commented Sep 23, 2021

This is "PR 2" as mentioned here #836

This removes the bindAutoResizeDataGrid() call from bindResizeHook as its already called from resizerService.init.
In Slickgrid vanilla & Aurelia it's also not done from bindResizeHook.

I have run all unit & cypress tested and tested some resizes manually and all look good.

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #839 (6bc77be) into master (fb5d656) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #839   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1075      1074    -1     
  Branches       334       340    +6     
=========================================
- Hits          1075      1074    -1     
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5d656...6bc77be. Read the comment docs.

@ghiscoding ghiscoding merged commit cee71c8 into ghiscoding:master Sep 24, 2021
@ghiscoding
Copy link
Owner

good catch, I also tried and it seems all good indeed. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants