Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filters): add optional filterTypingDebounce for filters w/keyup #720

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

ghiscoding
Copy link
Owner

  • we previously had the filterTypingDebounce but that was only available when using BackendServiceApi (with OData/GraphQL) but this PR goes further and makes it available to any type of grids, so it can now be used with a local grid (JSON dataset)
  • we also move the debounce code from the Filter Service into each filter component itself (only the following 2 filters requires this, InputFilter and CompoundInputFilter). The Filter Service shouldn't do any debounce, it should be the responsability of the concerned filter and that is what we refactored in this PR as well.

- we previously had the `filterTypingDebounce` but that was only available when using `BackendServiceApi` (with OData/GraphQL) but this PR goes further and makes it available to any type of grids, so it can now be used with a local grid (JSON dataset)
- we also move the debounce code from the Filter Service into each filter component itself (only the following 2 filters requires this, `InputFilter` and `CompoundInputFilter`). The Filter Service shouldn't do any debounce, it should be the responsability of the concerned filter and that is what we refactored in this PR as well.
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #720 (88f3592) into master (cf6593a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #720   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          159       159           
  Lines        10691     10691           
  Branches      3788      3786    -2     
=========================================
  Hits         10691     10691           
Impacted Files Coverage Δ
...lickgrid/components/angular-slickgrid.component.ts 100.00% <100.00%> (ø)
...s/angular-slickgrid/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
...p/modules/angular-slickgrid/filters/inputFilter.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/filters/inputMaskFilter.ts 100.00% <100.00%> (ø)
...dules/angular-slickgrid/services/filter.service.ts 100.00% <100.00%> (ø)
...modules/angular-slickgrid/services/sort.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6593a...88f3592. Read the comment docs.

@ghiscoding ghiscoding merged commit b4deea9 into master Mar 18, 2021
@ghiscoding ghiscoding deleted the feat/local-filter-debounce branch March 18, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant