Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extensions): Row Detail not always refreshing w/customId, fixes #546 #550

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Aug 3, 2020

  • refresh of each row detail not happening correctly with "datasetIdPropName", this was due to the fact that the View is saved as a "CreatedView" interface and that is kept with "id" not with "datasetIdPropName"
  • found out that I made a mistake when adding the datasetIdPropName, I keep the View with an id not with the dynamic datasetIdPropName and so I was keeping all the Views with undefined instead of their correct associated id (or custom id)... long story short, the refresh of each Row Detail wasn't working correctly with using a custom Id with datasetIdPropName
  • fixes Expanding multiple rows cleans the row expand view of the earlier expanded rows #546



- refresh of each row detail not happening correctly with "datasetIdPropName", this was due to the fact that the View is saved as a "CreatedView" interface and that is kept with "id" not with "datasetIdPropName"
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #550 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #550    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          148       148            
  Lines         9717      9717            
  Branches      3273      3412   +139     
==========================================
  Hits          9717      9717            
Impacted Files Coverage Δ
...lar-slickgrid/extensions/rowDetailViewExtension.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45bf561...ca61048. Read the comment docs.

@ghiscoding ghiscoding merged commit 324f490 into master Aug 3, 2020
@ghiscoding ghiscoding deleted the fix/row-detail-with-custom-id branch August 3, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanding multiple rows cleans the row expand view of the earlier expanded rows
2 participants