Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pinning): add "Frozen Columns" to header menu #494

Merged
merged 4 commits into from
Jun 29, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 12, 2020

  • this feature will basically allow the user to freeze all columns until the current position of the column header he opened. For example if user is opening column 4 header menu and click on "Frozen Columns", it will freeze all 4 columns on the left.

  • requires PR #513 on core lib to be

    • merged
    • and released

AGrRe27eQZ

- this feature will basically allow the user to freeze all columns until the current position of the column header he opened. For example if user is opening column 4 header menu and click on "Frozen Columns", it will freeze all 4 columns on the left.
@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #494   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          148       148           
  Lines         9589      9621   +32     
  Branches      3208      3221   +13     
=========================================
+ Hits          9589      9621   +32     
Impacted Files Coverage Δ
src/app/modules/angular-slickgrid/constants.ts 100.00% <ø> (ø)
...ular-slickgrid/extensions/columnPickerExtension.ts 100.00% <100.00%> (ø)
.../angular-slickgrid/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...ngular-slickgrid/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
...r-slickgrid/services/groupingAndColspan.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cc371...2acbc7d. Read the comment docs.

@ghiscoding ghiscoding changed the title WIP - feat(pinning): add "Frozen Columns" to header menu feat(pinning): add "Frozen Columns" to header menu Jun 29, 2020
@ghiscoding ghiscoding merged commit 7782ad3 into master Jun 29, 2020
@ghiscoding ghiscoding deleted the feat/pin-to-left-header-menu branch June 29, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants