Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): add Sort icon hint on hover when column is sortable #435

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

ghiscoding
Copy link
Owner

  • we now show a hint while hovering the column. It helps identify if the hovering column is sortable or not, if user doesn't want this behavior he can simply change the SASS variable to opacity of 0.

- we now show a hint while hovering the column. It helps identify if the hovering column is sortable or not, if user doesn't want this behavior he can simply change the SASS variable to opacity of 0.
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #435 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         8899      8899           
  Branches      2948      2948           
=========================================
  Hits          8899      8899           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5a150...baa004f. Read the comment docs.

@ghiscoding ghiscoding merged commit a746c2d into master Apr 28, 2020
@ghiscoding ghiscoding deleted the feat/styling-sort-icon-hint branch April 28, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants