Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odata query does not escape single quote #328

Closed
whtan98 opened this issue Oct 29, 2019 · 4 comments
Closed

odata query does not escape single quote #328

whtan98 opened this issue Oct 29, 2019 · 4 comments
Labels

Comments

@whtan98
Copy link
Contributor

whtan98 commented Oct 29, 2019

I'm submitting a Bug report

Your Environment

Software Version(s)
Angular 8
Angular-Slickgrid 2.12.2

Context

Whenever a fitler value eg. lee's is entered, the generated odata query fails to escape single quote with 2 single quotes

Expected Behavior

$count=true&$top=20&$orderby=Name asc&$filter=(contains(Name, 'lee''s'))

Current Behavior

$count=true&$top=20&$orderby=Name asc&$filter=(contains(Name, 'lee's'))

image

@ghiscoding
Copy link
Owner

I'd be happy to have a PR fixing it... if I look quickly at the code I do see that I double up the single quote on this line, so I'm not sure why it doesn't work

@ghiscoding ghiscoding added the bug label Oct 29, 2019
ghiscoding added a commit that referenced this issue Oct 29, 2019
…aping

fix(odata): filter with single quote should be escaped, fixes #328
@ghiscoding
Copy link
Owner

I had to do a quick fix for GraphQL Service, so I fixed your issue at the same time and released it under latest version 2.12.3. The GitHub demo was also updated.

ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this issue Oct 30, 2019
ghiscoding added a commit to ghiscoding/aurelia-slickgrid that referenced this issue Oct 30, 2019
@whtan98
Copy link
Contributor Author

whtan98 commented Oct 30, 2019

Thanks a lot for speedy release.

@ghiscoding
Copy link
Owner

You're welcome, thanks for the good feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants