fix(footer): tweak date format in custom footer for redability (#518)

* fix(footer): tweak date format in custom footer for redability
ghiscoding · Jul 9, 2020 · b2a0823 · b2a0823
1 parent f6cd58c
commit b2a0823
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/app/examples/grid-localization.component.ts b/src/app/examples/grid-localization.component.ts
@@ -159,7 +159,7 @@ export class GridLocalizationComponent implements OnInit {
           ofKey: 'OF',
           lastUpdateKey: 'LAST_UPDATE',
         },
-        dateFormat: 'yyyy-MM-dd hh:mm aaaaa\'m\'',
+        dateFormat: 'yyyy-MM-dd, hh:mm aaaaa\'m\'',
         hideTotalItemCount: false,
         hideLastUpdateTimestamp: false,
       },

diff --git a/src/app/modules/angular-slickgrid/components/__tests__/angular-slickgrid-constructor.spec.ts b/src/app/modules/angular-slickgrid/components/__tests__/angular-slickgrid-constructor.spec.ts
@@ -1320,7 +1320,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
           expect(component.columnDefinitions).toEqual(mockColDefs);
           expect(component.showCustomFooter).toBeTrue();
           expect(component.customFooterOptions).toEqual({
-            dateFormat: 'yyyy-MM-dd hh:mm aaaaa\'m\'',
+            dateFormat: 'yyyy-MM-dd, hh:mm aaaaa\'m\'',
             hideLastUpdateTimestamp: true,
             hideTotalItemCount: false,
             footerHeight: 20,
@@ -1358,7 +1358,7 @@ describe('Angular-Slickgrid Custom Component instantiated via Constructor', () =
           expect(component.columnDefinitions).toEqual(mockColDefs);
           expect(component.showCustomFooter).toBeTrue();
           expect(component.customFooterOptions).toEqual({
-            dateFormat: 'yyyy-MM-dd hh:mm aaaaa\'m\'',
+            dateFormat: 'yyyy-MM-dd, hh:mm aaaaa\'m\'',
             hideLastUpdateTimestamp: true,
             hideTotalItemCount: false,
             footerHeight: 20,

diff --git a/src/app/modules/angular-slickgrid/global-grid-options.ts b/src/app/modules/angular-slickgrid/global-grid-options.ts
@@ -52,7 +52,7 @@ export const GlobalGridOptions: Partial<GridOption> = {
     width: 200,
   },
   customFooterOptions: {
-    dateFormat: 'yyyy-MM-dd hh:mm aaaaa\'m\'',
+    dateFormat: 'yyyy-MM-dd, hh:mm aaaaa\'m\'',
     hideTotalItemCount: false,
     hideLastUpdateTimestamp: true,
     footerHeight: 20,

diff --git a/test/cypress/integration/example12.spec.js b/test/cypress/integration/example12.spec.js
@@ -43,7 +43,7 @@ describe('Example 12: Localization (i18n)', () => {
         .should($span => {
           const text = removeExtraSpaces($span.text()); // remove all white spaces
           const now = new Date();
-          const dateFormatted = moment(now).format('YYYY-MM-DD hh:mm a');
+          const dateFormatted = moment(now).format('YYYY-MM-DD, hh:mm a');
           expect(text).to.eq(`Last Update ${dateFormatted} | 1500 of 1500 items`);
         });
     });
@@ -104,7 +104,7 @@ describe('Example 12: Localization (i18n)', () => {
         .should($span => {
           const now = new Date();
           const text = removeExtraSpaces($span.text()); // remove all white spaces
-          const dateFormatted = moment(now).format('YYYY-MM-DD hh:mm a');
+          const dateFormatted = moment(now).format('YYYY-MM-DD, hh:mm a');
           expect(text).to.eq(`Dernière mise à jour ${dateFormatted} | 1500 de 1500 éléments`);
         });
     });