Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http_proxy/no_proxy env variables in Node.js #99

Open
slonopotamus opened this issue Mar 25, 2023 · 1 comment
Open

Comments

@slonopotamus
Copy link

When running asciidoctor-kroki in Node.js environment, it ignores http_proxy/no_proxy env variables. Cause: nodejs/node#8381

Note that when asciidoctor-kroki is run through Ruby, proxy vars are properly respected.

@ggrossetie ggrossetie transferred this issue from asciidoctor/asciidoctor-kroki Mar 26, 2023
@ggrossetie
Copy link
Owner

It's a shame... I guess we could implement the same logic as: https://gitlab.com/antora/antora/-/blob/main/packages/content-aggregator/lib/git-plugin-http.js#L32-46 using https://github.com/delvedor/hpagent

Since unxhr is used in Opal, I need to check if it's OK to add a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants