Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp accuracy needs to be improved #1657

Closed
erturkdotgg opened this issue Dec 19, 2023 · 4 comments · Fixed by #1485
Closed

Timestamp accuracy needs to be improved #1657

erturkdotgg opened this issue Dec 19, 2023 · 4 comments · Fixed by #1485
Labels
enhancement New feature or request question Further information is requested

Comments

@erturkdotgg
Copy link

Timestamp accuracy is very problematic. Often subtitles start showing too early. When one subtitle ends, the next subtitle is shown immediately instead of disappearing and waiting for the speech. This is because there is no time gap between the two subtitles. The other whisper modifications (whisperX, faster-whisper, whisper-timestamped) do not have this problem. Only whisper.ccp has this problem. This needs to be fixed.

@bobqianic bobqianic added the question Further information is requested label Dec 20, 2023
@bobqianic
Copy link
Collaborator

See #1485

@erturkdotgg
Copy link
Author

See #1485

Is it possible to use the changes in that topic? Like beta? Or is it just too early?

@bmurray
Copy link
Contributor

bmurray commented Dec 21, 2023

It's still too early to use it in production IMHO. It's close but theres some issues that need to get sorted.

@bobqianic bobqianic added the enhancement New feature or request label Jan 16, 2024
@bobqianic bobqianic linked a pull request Jan 16, 2024 that will close this issue
11 tasks
@YeDaxia
Copy link

YeDaxia commented Mar 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants