Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server.cpp is not accepting parameter -tb N, --threads-batch N #3473

Closed
jubruckne opened this issue Oct 4, 2023 · 1 comment · Fixed by #3584
Closed

server.cpp is not accepting parameter -tb N, --threads-batch N #3473

jubruckne opened this issue Oct 4, 2023 · 1 comment · Fixed by #3584
Labels
good first issue Good for newcomers

Comments

@jubruckne
Copy link

jubruckne commented Oct 4, 2023

Expected Behavior

server.cpp should recognise parameters -tb / --threads-batch (as stated in the readme).

Please provide a detailed written description of what llama.cpp did, instead.

server.cpp doesn't recognise the -tb / --threads-batch parameter.

I checked the code, this options seems indeed missing.

PS: I can attempt adding it, if you agree... it would be a good task to get started on the code.

@ggerganov ggerganov added the good first issue Good for newcomers label Oct 4, 2023
@m18coppola
Copy link
Contributor

m18coppola commented Oct 4, 2023

I have made a fork of this repo with the changes needed to add --threads-batch / --tb to server.cpp, what is the best way to make a PR?

Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants