Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wgpu-info into a proper CLI Tool #3856

Merged
merged 7 commits into from
Jun 15, 2023

Conversation

cwfitzgerald
Copy link
Member

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.

Description

One pre-component for #3680 is being able to generate a machine-readable report of the user's GPU so that tests can be filtered very quickly based on it.

This reworks wgpu-info into a proper CLI with options and the ability to dump information to json. Additionally, preparations are in place to publish it to crates, so other people can use it for testing purposes.

CCing @ErichDonGubler as the resident CLI-goto :)

Testing

Manually tested, will be part of the test flow soon.

@cwfitzgerald cwfitzgerald requested a review from teoxoy June 11, 2023 18:03
Wumpf
Wumpf previously requested changes Jun 13, 2023
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried it on my Mac, works nicely and looks pretty :). Code looks good to me as well.
But we need to fix that serde-feature build issue I pointed out. If you have a way to build the tool as is we can also handle that in a separate PR

wgpu-info/Cargo.toml Outdated Show resolved Hide resolved
@cwfitzgerald cwfitzgerald dismissed Wumpf’s stale review June 15, 2023 19:49

Problem fixed

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) June 15, 2023 19:49
@cwfitzgerald cwfitzgerald merged commit e6be20f into gfx-rs:trunk Jun 15, 2023
@cwfitzgerald cwfitzgerald deleted the wgpu-info-stronk branch June 15, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants