GLES Wayland: properly resize on configure (#2094) #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Dec 12, 2021
kvark
added
the
PR: needs back-porting
kvark
removed
the
PR: needs back-porting
cwfitzgerald
pushed a commit
that referenced
this pull request
Oct 25, 2023
…2294) We currently assume that we are using raw `RWByteAddressBuffer` methods for all atomic operations (`<pointer>.Interlocked<op>(<raw_byte_offset>, …)`), which is only true when we use `var<storage, read_write>` globals. For `var<workgroup>` globals, we need `Interlocked<op>(<pointer>, …)`, using the original expression as the first argument. Fix this by branching on the `pointer`'s address space in `Atomic` statements, and implementing the workgroup address space case with intrinsics. Remove atomic ops from `access`, add new `atomicOps` test. Fixes #2284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #2094
Description
Resizes Wayland window every configure() instead of only when creating the window.
Testing
Tested all examples on Arch Linux with swaywm on
AdapterInfo { name: "Mesa Intel(R) UHD Graphics (TGL GT2)", vendor: 32902, device: 0, device_type: IntegratedGpu, backend: Gl }Results: hello-triangle, cube, shadow, water examples are fixed. No new errors in the examples.
Ran 'cargo test', which had similar errors both before and after, like:
[2021-12-12T16:13:23Z ERROR wgpu_hal::gles::egl] EGL 'eglMakeCurrent' code 0x3006: eglMakeCurrent[2021-12-12T16:13:23Z ERROR wgpu_hal::gles::egl] EGL 'eglDestroyContext' code 0x3006: eglDestroyContext