-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Merge naga
into wgpu
Repository
#4231
Comments
I am very much in favor of this. A lot of friction came from having to juggle between the two repository while implementing the I'll also add that the separation currently leads to different people changing naga's API and figuring out how to adapt wgpu to the changes. It would also simplify the process of updating firefox and testing naga changes in firefox. |
As someone with a few crates that use naga but not wgpu, as long as they stay as separate crates then I'm not sure what would change from my user perspective with this merge. The only thing I'd want is for the versioning and release schedule for both to stay somewhat independent, to allow for the timely addition and release of Naga features which aren't utilised by WGPU. |
Nothing will change from the users perspective.
Breaking changes for both naga and wgpu have always been released at the same time, patches are released on a crate-by-crate level whenever they need it, even within the wgpu workspace, so that will also continue. |
After seeing the community and maintainer response we are going to go ahead with this, next week after the wgpu 0.18 release. We will make a point in the documentation of the new combined repo that naga is still a standalone project which has uses outside of wgpu. |
Premise
Currently, despite how tightly linked naga and wgpu are, they live in different repositories, with different issue trackers, and test suites. There are a number of problems that arise from this, and we are considering merging naga into the wgpu repository. This can be done without losing history (we did it before merging wgpu-rs and wgpu-core into a single repo).
I have tried to put together a balanced pro/con list for doing this and want to reach out to the broader community for what people's opinions are.
Pros
Cons
wgpu/naga's maintainers currently expect the result of this to be merging repositories, but we are open to any and all opinions, so if you have a stake in this, definitely make your voice heard!
The text was updated successfully, but these errors were encountered: