Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU Device Limits #3299

Closed
Tracked by #3674
unfolding18 opened this issue Dec 15, 2022 · 1 comment
Closed
Tracked by #3674

WebGPU Device Limits #3299

unfolding18 opened this issue Dec 15, 2022 · 1 comment
Labels
api: webgpu Issues with direct interface with WebGPU external: upstream Issues happening in lower level APIs or platforms help required We need community help to make this happen. type: bug Something isn't working

Comments

@unfolding18
Copy link

unfolding18 commented Dec 15, 2022

Is your feature request related to a problem? Please describe.
When compiling to WebGPU, you cannot specify device limits beyond the default limits provided by the implementation - for example, if you wish to request that the max_storage_buffer_binding_size limit be increased. Currently, any user-defined limits are simply ignored, as seen here: https://github.com/gfx-rs/wgpu/blob/master/wgpu/src/backend/web.rs#L1237

Additional context
After some discussion with several users on Matrix, it seems that the issue stems from the fact that web-sys doesn't have any bindings for setting the limits in https://docs.rs/web-sys/latest/web_sys/struct.GpuDeviceDescriptor.html

The struct contains a member that is record<DOMString, GPUSize64> requiredLimits, which apparently is where the problem starts (record<> is not supported by web-sys?). Maybe others can chime in with additional context here.

@cwfitzgerald cwfitzgerald added type: bug Something isn't working help required We need community help to make this happen. external: upstream Issues happening in lower level APIs or platforms api: webgpu Issues with direct interface with WebGPU labels Dec 15, 2022
@FL33TW00D
Copy link
Contributor

This was fixed with a polyfill for record in: #4107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: webgpu Issues with direct interface with WebGPU external: upstream Issues happening in lower level APIs or platforms help required We need community help to make this happen. type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants