Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict requests versions that break urllib3 and vcrpy #20

Closed
gferragu opened this issue May 4, 2023 · 0 comments · Fixed by #21
Closed

Restrict requests versions that break urllib3 and vcrpy #20

gferragu opened this issue May 4, 2023 · 0 comments · Fixed by #21
Assignees
@gferragu
Labels
bug Something isn't working gmprocess

Comments

@gferragu
Copy link
Owner

gferragu commented May 4, 2023 •
edited
Loading

Recent requests releases (I think including and above 2.29.0) fail to support urllib3 2.0.0 and above.

This causes the unit tests to fail when pytest is run and calls vcrpy.

A fix for this in gmprocess will come out in the next release for PyPi and Conda-Forge, but in the meantime I can just restrict the versioning here to allow the tests to run without issue

See discussion in the requests repo and vcrpy repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gferragu gferragu

Labels
bug Something isn't working gmprocess
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin requests version to avoid breaking unit tests gferragu/ESI-build-tests
1 participant
@gferragu