Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Investigate whether we need to use base64url encoding in FCL lib #84

Closed
JohnGuilding opened this issue Sep 14, 2023 · 0 comments · Fixed by #106
Closed

Investigate whether we need to use base64url encoding in FCL lib #84

JohnGuilding opened this issue Sep 14, 2023 · 0 comments · Fixed by #106
Assignees

Comments

@JohnGuilding
Copy link
Contributor

JohnGuilding commented Sep 14, 2023

In order to correctly validate the client challenge, we had to use base64url encoding over base64 encoding. The Fresh crypto lib seems to give conflicting options on what you can do. The implementation under src/ use base64 whereas the implementation that is actually tests against in the same repo uses base64url encoding.

We should investigate what encoding we should actually use.

@JohnGuilding JohnGuilding converted this from a draft issue Sep 14, 2023
@JohnGuilding JohnGuilding self-assigned this Sep 29, 2023
@JohnGuilding JohnGuilding moved this from 📋 Backlog to 🛠 In Progress in Wallet Account eXperiments (WAX) Sep 29, 2023
@JohnGuilding JohnGuilding moved this from 🛠 In Progress to 🧐 In review in Wallet Account eXperiments (WAX) Sep 29, 2023
@JohnGuilding JohnGuilding linked a pull request Oct 2, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🧐 In review to 🤝 Done in Wallet Account eXperiments (WAX) Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant