Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Device Context with CPU info #77

Closed
4 tasks done
markushi opened this issue Feb 20, 2023 · 7 comments
Closed
4 tasks done

Extend Device Context with CPU info #77

markushi opened this issue Feb 20, 2023 · 7 comments

Comments

@markushi
Copy link
Member

markushi commented Feb 20, 2023

Our device context docs describe a few new CPU related fields which are not provided by the mobile SDKs yet.

  • processor_count
  • cpu_description
  • processor_frequency

Platforms

  1. Effort: Medium Effort: Small Platform: Android Platform: Java
    markushi
  2. Effort: Small Impact: Medium Platform: Cocoa Status: Backlog
    brustolin
  3. Platform: React-Native
    krystofwoldrich

GH discussion on device classification getsentry/sentry#44422

@edwardgou-sentry
Copy link

Hey @markushi! I'm working on utilizing these fields in parallel, can I assume that processor_count will just be a simple number value and processor_frequency will be a number value representing frequency in mhz (ie 2500 for 2500mhz/2.5ghz)? This is also how this data is stored in profiles from what I can tell.

@kahest
Copy link
Member

kahest commented Feb 24, 2023

Hey @edwardgou-sentry! We want to adhere to the way of reporting these fields that exists from Profiling, so it's safe to assume this!

@edwardgou-sentry
Copy link

Awesome! Thanks @kahest ! 🙏

@brustolin
Copy link

It seems that for iOS there is no reliable way to retrieve CPU description or frequency.
The workarounds suggest to hard code the device model with such information, I think we should do this in the server side to avoid the need to update the SDK to include more information on every new device release.

We just need to compile an updated list like the one in this

@markushi
Copy link
Member Author

@edwardgou-sentry before merging the Android PR, could you help me clarify the following:

  1. do you know if the processor_count should be the number of logical cores or physical cores?
  2. the processor_frequency is defined as a single number in the protocol, but can be different for every core - I assume we want to send over the highest value right?

@markushi
Copy link
Member Author

@edwardgou-sentry any chance you could take a look into my questions above?

@edwardgou-sentry
Copy link

edwardgou-sentry commented Mar 28, 2023

Hey @markushi , sorry I missed this!

  1. This should be number of physical cores
  2. Yes, we're looking for the highest performance core here

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

6 participants