Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send request body for http client integrations and similar #41

Open
1 of 8 tasks
adinauer opened this issue Jul 27, 2022 · 4 comments
Open
1 of 8 tasks

Send request body for http client integrations and similar #41

adinauer opened this issue Jul 27, 2022 · 4 comments

Comments

@adinauer
Copy link
Member

adinauer commented Jul 27, 2022

Different SDKs have different HTTP library integrations.
We plan to generate events directly from these integrations when we detect failed HTTP response status code.

Additionally, we can attach the request and/or response bodies. This feature exists in some for in some SDKs, we'd like to discuss in a broader SDK group and define details and write the develop docs.

  • Check which integrations already do it. Add checklist with integrations with their status.
  • Amend develop docs. We have the current develop docs direction for HTTP library integrations
    • Maybe it should be done via attachments?
    • it doesn't say anything about Request or Response body.
    • It currently has no note regarding PII.
    • Add docs on how to deal with gotchas, how to strip data in callbacks etc.
  • Public facing docs should be written under common and opt'ted-in in platforms that support it as we go.

SDKs:

@marandaneto
Copy link

marandaneto commented Oct 27, 2022

This requires an RFC since it should be an attachment instead of a data field in the event protocol, PII concerns, etc.
Relates to getsentry/sentry-dart#624 (comment)

@mattjohnsonpint
Copy link

JavaScript SDK: getsentry/sentry-javascript#7287

@jamescrosswell
Copy link

jamescrosswell commented Aug 28, 2023

I see this was moved from blocked to backlog back in June. However it looks like some key design decisions still need to be made before we could start work:

  • Mainly we need to decide whether the bodies would be added as attachments... my 2c:
    • This should be consistent with how we capture the payload when handling server requests in ASP.NET Core
      • Currently captured in the request/response interfaces on the transaction
    • Whatever we do here we presumably also want to do for GraphQL Clients and Servers as well
  • Ideally the develop docs would be updated summarizing key decisions comming out of the above discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Status: No status
Development

No branches or pull requests

6 participants