From b82ec01ea29722cc12584c7d43e84acc128a0bba Mon Sep 17 00:00:00 2001 From: Lyn Date: Mon, 17 Oct 2022 11:30:50 -0700 Subject: [PATCH 1/2] feat(devserver): Run separate transactions post process forwarder Combined post process forwarder no longer works with Sentry/Snuba defaults (fully separated errors/transactions topics). Running a combined PPF caused this error in self hosted: https://github.com/getsentry/sentry/issues/40120. --- src/sentry/runner/commands/devserver.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/sentry/runner/commands/devserver.py b/src/sentry/runner/commands/devserver.py index 861f09c0f21191..68047405fdc911 100644 --- a/src/sentry/runner/commands/devserver.py +++ b/src/sentry/runner/commands/devserver.py @@ -18,11 +18,22 @@ "sentry", "run", "post-process-forwarder", - "--entity=all", + "--entity=errors", "--loglevel=debug", "--commit-batch-size=100", "--commit-batch-timeout-ms=1000", ], + "post-process-forwarder-transactions": [ + "sentry", + "run", + "post-process-forwarder", + "--entity=transactions", + "--loglevel=debug", + "--commit-batch-size=100", + "--commit-batch-timeout-ms=1000", + "--commit-log-topic=snuba-transactions-commit-log", + "--synchronize-commit-group=transactions_group", + ], "ingest": ["sentry", "run", "ingest-consumer", "--all-consumer-types"], "region_to_control": ["sentry", "run", "region-to-control-consumer", "--region-name", "_local"], "server": ["sentry", "run", "web"], From 6f937cfa478a7e3962361ae3a62bcf282b03a4cc Mon Sep 17 00:00:00 2001 From: Lyn Date: Mon, 17 Oct 2022 11:45:51 -0700 Subject: [PATCH 2/2] add daemon --- src/sentry/runner/commands/devserver.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sentry/runner/commands/devserver.py b/src/sentry/runner/commands/devserver.py index 68047405fdc911..5c46954451f879 100644 --- a/src/sentry/runner/commands/devserver.py +++ b/src/sentry/runner/commands/devserver.py @@ -261,6 +261,7 @@ def devserver( if eventstream.requires_post_process_forwarder(): daemons += [_get_daemon("post-process-forwarder")] + daemons += [_get_daemon("post-process-forwarder-transactions")] if settings.SENTRY_EXTRA_WORKERS: daemons.extend([_get_daemon(name) for name in settings.SENTRY_EXTRA_WORKERS])