feat(forms): Migrate to react-textarea-autosize
#83357
Merged
+38
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by the person that does makes emotion https://www.npmjs.com/package/react-textarea-autosize seems to work about the same. The previous package we were using is archived 2024 https://github.com/buildo/react-autosize-textarea
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Jan 14, 2025
| @@ -69,7 +69,6 @@ jest | |||
| .spyOn(performanceForSentry, 'VisuallyCompleteWithData') | |||
| .mockImplementation(props => props.children as ReactElement); | |||
| jest.mock('scroll-to-element', () => jest.fn()); | |||
| jest.mock('sentry/utils/search/searchBoxTextArea'); | |||
There was a problem hiding this comment.
i don't think this is being used anymore?
There was a problem hiding this comment.
yes it seems it is no longer used.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #83357 +/- ##
==========================================
- Coverage 87.48% 81.91% -5.58%
==========================================
Files 9406 9406
Lines 537275 537275
Branches 21158 21158
==========================================
- Hits 470042 440088 -29954
- Misses 66876 96830 +29954
Partials 357 357 |
| @@ -69,7 +69,6 @@ jest | |||
| .spyOn(performanceForSentry, 'VisuallyCompleteWithData') | |||
| .mockImplementation(props => props.children as ReactElement); | |||
| jest.mock('scroll-to-element', () => jest.fn()); | |||
| jest.mock('sentry/utils/search/searchBoxTextArea'); | |||
There was a problem hiding this comment.
yes it seems it is no longer used.
Bundle ReportChanges will increase total bundle size by 43.57kB (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
evanpurkhiser
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by the person that does emotion https://www.npmjs.com/package/react-textarea-autosize seems to work about the same. The previous package we were using is archived and last updated 4 years ago https://github.com/buildo/react-autosize-textarea
this new version drops the prop types package and has updated peer dependencies etc