Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(streamline): Add an option to remove opt-out for new users #83205

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(streamline): Add an option to remove opt-out for new users #83205

wants to merge 7 commits into from
+154 −58

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Jan 9, 2025 •
edited
Loading

Adds an option assigned to new organizations such that all members of the organization receive either the new UI or legacy UI without the ability to opt into one or the other.

This work doesn't actually do any of the UI enforcement, that will be in a correlated Frontend PR that needs to be merged first.

todo

  • Add some tests to ensure the options are set

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/endpoints/organization_index.py 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #83205       +/-   ##
===========================================
+ Coverage   63.42%   87.55%   +24.13%     
===========================================
  Files        4220     9385     +5165     
  Lines      129995   537188   +407193     
  Branches    21113    21113               
===========================================
+ Hits        82444   470322   +387878     
- Misses      47192    66507    +19315     
  Partials      359      359

@leeandher leeandher marked this pull request as ready for review January 9, 2025 22:23
@leeandher leeandher requested a review from a team as a code owner January 9, 2025 22:23
@leeandher leeandher mentioned this pull request Jan 10, 2025
Merged
leeandher added a commit that referenced this pull request Jan 10, 2025
@leeandher
feat(streamline): Allow the new UI to reflect the organization option (…
4b7df0b 
…#83238)

Adds the organization option to be read from the changes in
#83205 and reflect them in the
UI, along with tests.

This should be merged first, so that once the backend begins applying
the flags, the frontend new orgs are served can already reflect the
changes.
roggenkemper
roggenkemper approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@roggenkemper roggenkemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good changes! also means we can merge this before we are ready to start rolling it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roggenkemper roggenkemper roggenkemper approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeandher @roggenkemper