Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the event and occurrence available in post_process_group #42531

Closed
Tracked by #42044
wedamija opened this issue Dec 21, 2022 · 0 comments
Closed
Tracked by #42044

Make the event and occurrence available in post_process_group #42531

wedamija opened this issue Dec 21, 2022 · 0 comments
Assignees

Comments

@wedamija
Copy link
Member

wedamija commented Dec 21, 2022

Currently, post_process_group is passed a cache key, which is used to fetch the event from eventstore:

data = event_processing_store.get(cache_key)
if not data:
logger.info(
"post_process.skipped",
extra={"cache_key": cache_key, "reason": "missing_cache"},
)
return
with metrics.timer("tasks.post_process.delete_event_cache"):
event_processing_store.delete_by_key(cache_key)
event = process_event(data, group_id)

We aren't currently writing this event to eventstore in the issue platform. We have a couple of options here:

  • As part of our ingest pipeline, write the event data to eventstore and keep using it as before.
  • In post_process_group, when dealing with an issue platform issue, instead of using eventstore we could fetch the event from nodestore. This might make things better for our overall architecture in the future, since we won't have to wait for the slow post_process_group step to complete before we clear the cache.

As well as this, we need to make sure to fetch the occurrence and associate it with the GroupEvent. To do this, we'll need to pass the occurrence id along to post_process_group and load it from nodestore.

@wedamija wedamija assigned wedamija and unassigned wedamija Jan 10, 2023
@wedamija wedamija self-assigned this Jan 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant