-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config SENTRY_MAX_MESSAGE_LENGTH does not work #13585
Comments
9.1.1 should have a limit of 8000 chars. Which message attribute do you mean? Could you provide a screenshot? |
Sorry, I rechecked, I see it truncate at 8000 chars like you said, Is there any way to increase this limit number? |
I found in 9.1 that --- sentry/src/sentry-dev/src/sentry/event_manager_9.1.py 2019-04-25 10:06:31.000000000 -0700
+++ sentry/src/sentry-dev/src/sentry/event_manager_new.py 2019-04-25 10:06:48.000000000 -0700
@@ -444,7 +444,7 @@
valid_platforms=list(VALID_PLATFORMS),
max_secs_in_future=MAX_SECS_IN_FUTURE,
max_secs_in_past=MAX_SECS_IN_PAST,
- enable_trimming=True,
+ enable_trimming=False,
is_renormalize=self._is_renormalize
) And in our Dockerfile,
|
@untitaker do you know whether this was intentional or not? |
We didn't think that people would care about this setting. I would be cool with a single setting that just turns of trimming altogether (like in @caseyduquettesc's patch) assuming that's fine-grained enough for most people who want this. Just make sure it's |
@caseyduquettesc , just tested. It works like a charm. you save my time. Thanks |
It might be worth noting here that we're planning to move all of that code into a new, separate service. As part of this, many of these settings might no longer be configurable going forward (such as trimming, for instance). Might I ask what the use case is for such large messages? With event attachments (basically file uploads that show up on the issue details screen), we might have a suitable alternative in Sentry 10. |
@jan-auer I completely understand that your roadmap may not necessarily support my use case and we've accepted that we have sort of gone off book here. I appreciate that you asked though and hope you just continue to keep doing what's best for the product, it's great. A warning for anyone else disabling trimming and inserting large messages - it will absolutely kill your snuba/clickhouse service with searching large messages. I had to just disable message searching entirely for this one project until I can figure out either how to reduce the message size just in clickhouse or migrating message searching to something like elastic search. |
Closing this issue due to staleness. Feel free to comment here if you think we should still work on this. Regarding @jan-auer's last message, this new service, Relay, is now part of Sentry deploys. You can find more information over at the docs: https://docs.sentry.io/product/relay/ |
Hi,
I config SENTRY_MAX_MESSAGE_LENGTH to another number, but the message always be truncated at 1000 characters, how can i make it work?
I'm using sentry server version Sentry 9.1.1
Thanks,
The text was updated successfully, but these errors were encountered: