From 8e4858c4a4e1e968a55b79480828796ed95e5199 Mon Sep 17 00:00:00 2001 From: edwardgou-sentry <83961295+edwardgou-sentry@users.noreply.github.com> Date: Wed, 11 Dec 2024 10:30:53 -0500 Subject: [PATCH] fix(alerts): Fix EAP alert filter bar to behave more like explore (#81946) Updates the search bar in the EAP Alert edit page to behave more like explore: - User must explicitly save changes on the search (hitting enter) for updates to take effect. Same as explore. - Removed onBlur handler This also fixes an issue where the chart visualization updates, but saving the alert rule doesn't actually save the changed filter because it was not actually committed --- static/app/views/alerts/rules/metric/ruleConditionsForm.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/static/app/views/alerts/rules/metric/ruleConditionsForm.tsx b/static/app/views/alerts/rules/metric/ruleConditionsForm.tsx index e19903f5fcc8e1..11f628c409fc6e 100644 --- a/static/app/views/alerts/rules/metric/ruleConditionsForm.tsx +++ b/static/app/views/alerts/rules/metric/ruleConditionsForm.tsx @@ -781,16 +781,12 @@ class RuleConditionsForm extends PureComponent { { onFilterSearch(query, parsedQuery); onChange(query, {}); }} - onBlur={(query, {parsedQuery}) => { - onFilterSearch(query, parsedQuery); - onBlur(query); - }} supportedAggregates={ALLOWED_EXPLORE_VISUALIZE_AGGREGATES} projects={[parseInt(project.id, 10)]} />