Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lambda layer retrieval #176

Open
andreiborza opened this issue Dec 30, 2024 · 0 comments
Open

Improve lambda layer retrieval #176

andreiborza opened this issue Dec 30, 2024 · 0 comments

Comments

@andreiborza
Copy link
Member

Description

Today, there's one endpoint for fetching AWS lambda layer information from the release registry. This endpoint lumps node and python targets together and only returns information on the latest versions (of the latest majors) of each target.

This release registry information is used in the docs to populate this dropdown
Image

Problem

With the v8 major of the sentry-javascript SDKs, we introduced a new layer for v7 published under its own name:
https://github.com/getsentry/sentry-javascript/blob/bc7dfd64961cc85405ca0d2ae91ea6545847a1de/.craft.yml#L147-L163

But, given the endpoint only returns information on the latest major, we cannot provide an ARN dropdown for users of previous majors. Instead, ARNs are hardcoded in the docs and are immediately out of date.

Solution Brainstorming

A couple of potential solutions:

  • Add another layer underneath targets for each major, e.g. node/v7/latest.json, node/v8/latest.json, python/v3/latest.json and combine them all in the existing api endpoint
  • Provide an endpoint to query the latest info of a given major, e.g. https://release-registry.services.sentry.io/aws-lambda-layers/node/7 for
    the latest node layer for the v7 major. SDKs have such an endpoint, e.g. https://release-registry.services.sentry.io/sdks/sentry.javascript.node/7.120.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant