From b9c41b60be685adf5ab9e25872311a9e712cab53 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Thu, 18 Aug 2022 09:24:53 +0200 Subject: [PATCH 1/2] ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout --- CHANGELOG.md | 6 ++++++ src/js/tracing/reactnativetracing.ts | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae85725389..e86c323909 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,11 @@ # Changelog +## Unreleased + +### Fixes + +- ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout ([#2398](https://github.com/getsentry/sentry-react-native/pull/2398)) + ## 4.2.3 ### Fixes diff --git a/src/js/tracing/reactnativetracing.ts b/src/js/tracing/reactnativetracing.ts index bd35416af0..4b006c85b5 100644 --- a/src/js/tracing/reactnativetracing.ts +++ b/src/js/tracing/reactnativetracing.ts @@ -361,7 +361,7 @@ export class ReactNativeTracing implements Integration { hub as Hub, expandedContext, idleTimeout, - idleTimeout, // BREAKCHANGE: check the correct parameter here + maxTransactionDuration, true ); From 8f5c53ebc3c9cb7c6e056894ec145e9f18209500 Mon Sep 17 00:00:00 2001 From: Manoel Aranda Neto Date: Thu, 18 Aug 2022 09:27:08 +0200 Subject: [PATCH 2/2] pr id --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e86c323909..8c72e7df47 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ ### Fixes -- ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout ([#2398](https://github.com/getsentry/sentry-react-native/pull/2398)) +- ReactNativeTracing wrongly marks transactions as deadline_exceeded when it reaches the idleTimeout ([#2427](https://github.com/getsentry/sentry-react-native/pull/2427)) ## 4.2.3