Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on bundling with the latest release #807

Closed
3 of 8 tasks
chgsilva opened this issue Mar 26, 2020 · 12 comments
Closed
3 of 8 tasks

Error on bundling with the latest release #807

chgsilva opened this issue Mar 26, 2020 · 12 comments

Comments

@chgsilva
Copy link
Contributor

chgsilva commented Mar 26, 2020

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

SDK:

  • @sentry/react-native
  • react-native-sentry

SDK version: 0.0.0
react-native version: 0.0.0

Are you using Expo?

  • Yes
  • [ x] No

Description goes here ...

Steps to reproduce:

  • Step
    Install the latest release

Actual result:

  • Actual
    When loading the bundle this error appears on the metro bundle:
error: bundling failed: Error: Unable to resolve module `domain` from `node_modules/@sentry/hub/dist/hub.js`: domain could not be found within the project.

Expected result:

  • Result
    bundle is loaded
@grobmeier
Copy link

Have the same issue with:
"@sentry/react-native": "^1.3.4",

Message:
Error: Unable to resolve module domainfromnode_modules/@sentry/hub/dist/hub.js: domain could not be found within the project.

My command to reproduce this:

react-native bundle --entry-file='index.js' --bundle-output='./ios/main.jsbundle' --dev=false --platform='ios'

@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

We are on it

@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

FYI this PR broke it
getsentry/sentry-javascript#2515

@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

Potential fix, we need to validate it with webpack but it works for react-native
getsentry/sentry-javascript#2521

Sorry about this issue getsentry/sentry-javascript#2515 (comment)

JS tooling is hard

@wmarsey
Copy link

wmarsey commented Mar 26, 2020

thanks for this quick work!

it looks like we can't downgrade out of the problem... I've been doing fresh installs etc and @sentry/[email protected] and 1.3.3 are both now resolving to @sentry/[email protected] with yarn, so I still can't build -- does that sound right?

@chgsilva
Copy link
Contributor Author

For anyone needing a workaround, I did a fork and locked the version.
The branch fix131 has the temporary solution.
https://github.com/PasseiDireto/sentry-react-native/tree/fix131

Thanks

@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

Sounds about right, we will do a new release today for sure

@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

New version of @sentry/* is released, a clean install should install 5.15.2 with the fix
I will release a new @sentry/react-native version as well with the bump.

Again, sorry for the inconvenience.

@HazAT HazAT closed this as completed Mar 26, 2020
@HazAT
Copy link
Member

HazAT commented Mar 26, 2020

1.3.5 has been released

@aknyazyan
Copy link

Hi guys,

I still have the same issue, even with 1.3.5 version.
Could you please check again?

@HazAT
Copy link
Member

HazAT commented Mar 27, 2020

@aknyazyan Please clean your node modules and lock file and make sure you get the @sentry/* dependencies above 5.15.2

@aknyazyan
Copy link

Removed node_modules, package-json.lock, installed 1.3.5 version. @sentry/* dependencies version is 5.15.2. Error exists (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants