-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of "@sentry/integrations" causes unnecessary files being added to the bundle #759
Comments
Thanks for reporting, this is definitely not intended. |
React Native/Metro does not support tree shaking, not sure how we can tackle this. @AbhiPrasad @bruno-garcia @jennmueng ideas? Edit: After getsentry/sentry-javascript#4240 is done, this is likely going to be improved since the integrations package will be reworked. |
@AbhiPrasad opened a PR that may help us out with that, getsentry/sentry-javascript#4434 |
There were a few improvements related to bundle size and integrations on the JS SDK, the RN SDK got it for free, please upgrade to the latest version (4.x) and let us know if that helped, thanks. |
Hey,
First of all, apologies if this is not an issue or not a suitable place to raise it. In this case, feel free to close it and let me know how to follow up.
I am debugging the end bundle of an application that uses Sentry and React Native integration and I have noticed that there are Angular, Ember and Vue integrations included in the resulting bundle.
After digging deeper, it looks like they are present in the entry file of
@sentry/integrations
that is loaded when we requireRewriteFrames
.Wouldn't it be more suitable to move that function to
@sentry/utils
? I don't find this particularly disturbing, but just figured I'd share this here as it was really surprising to see other frameworks being referenced in the code and find out where they're coming from.The text was updated successfully, but these errors were encountered: