Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 broke iOS compilation #648

Closed
2 of 5 tasks
strayer opened this issue Sep 2, 2019 · 2 comments
Closed
2 of 5 tasks

1.0.0 broke iOS compilation #648

strayer opened this issue Sep 2, 2019 · 2 comments

Comments

@strayer
Copy link

strayer commented Sep 2, 2019

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

v10.16.0
6.9.0
[email protected] /redacted
├── @react-native-community/[email protected]
├── @sentry/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] invalid
├── [email protected] invalid
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

npm ERR! invalid: [email protected] /redacted/node_modules/react-native-background-geolocation-android
npm ERR! extraneous: [email protected] /redacted/node_modules/react-native-background-geolocation-android/node_modules/plist
npm ERR! extraneous: [email protected] /redacted/node_modules/react-native-background-geolocation-android/node_modules/xcode
npm ERR! invalid: [email protected] /redacted/node_modules/react-native-config
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/babel-preset-fbjs/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/plugin-syntax-jsx/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/helper-create-class-features-plugin/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/plugin-syntax-nullish-coalescing-operator/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/plugin-syntax-optional-catch-binding/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/plugin-syntax-optional-chaining/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/metro-react-native-babel-transformer/node_modules/metro-react-native-babel-preset/node_modules/@babel/core
npm ERR! extraneous: @babel/[email protected] /redacted/node_modules/@babel/plugin-syntax-typescript/node_modules/@babel/core

iOS compilation fails with these build errors:

/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:125:17: error: use of undeclared identifier 'scope'; did you mean 'bcopy'?
    if (nil != [scope objectForKey:@"__sentry_release"]) {
                ^~~~~
                bcopy
In module 'Darwin' imported from /redacted/ios/Pods/Headers/Public/React-Core/React/RCTUtils.h:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.4.sdk/usr/include/strings.h:71:7: note: 'bcopy' declared here
void     bcopy(const void *, void *, size_t) __POSIX_C_DEPRECATED(200112L);
         ^
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:125:17: error: bad receiver type 'void (*)(const void *, void *, size_t)' (aka 'void (*)(const void *, void *, unsigned long)')
    if (nil != [scope objectForKey:@"__sentry_release"]) {
                ^~~~~
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:126:50: error: use of undeclared identifier 'scope'; did you mean 'bcopy'?
        SentryClient.sharedClient.releaseName = [scope objectForKey:@"__sentry_release"];
                                                 ^~~~~
                                                 bcopy
In module 'Darwin' imported from /redacted/ios/Pods/Headers/Public/React-Core/React/RCTUtils.h:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.4.sdk/usr/include/strings.h:71:7: note: 'bcopy' declared here
void     bcopy(const void *, void *, size_t) __POSIX_C_DEPRECATED(200112L);
         ^
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:126:50: error: bad receiver type 'void (*)(const void *, void *, size_t)' (aka 'void (*)(const void *, void *, unsigned long)')
        SentryClient.sharedClient.releaseName = [scope objectForKey:@"__sentry_release"];
                                                 ^~~~~
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:128:17: error: use of undeclared identifier 'scope'; did you mean 'bcopy'?
    if (nil != [scope objectForKey:@"__sentry_dist"]) {
                ^~~~~
                bcopy
In module 'Darwin' imported from /redacted/ios/Pods/Headers/Public/React-Core/React/RCTUtils.h:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.4.sdk/usr/include/strings.h:71:7: note: 'bcopy' declared here
void     bcopy(const void *, void *, size_t) __POSIX_C_DEPRECATED(200112L);
         ^
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:128:17: error: bad receiver type 'void (*)(const void *, void *, size_t)' (aka 'void (*)(const void *, void *, unsigned long)')
    if (nil != [scope objectForKey:@"__sentry_dist"]) {
                ^~~~~
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:129:43: error: use of undeclared identifier 'scope'; did you mean 'bcopy'?
        SentryClient.sharedClient.dist = [scope objectForKey:@"__sentry_dist"];
                                          ^~~~~
                                          bcopy
In module 'Darwin' imported from /redacted/ios/Pods/Headers/Public/React-Core/React/RCTUtils.h:8:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator12.4.sdk/usr/include/strings.h:71:7: note: 'bcopy' declared here
void     bcopy(const void *, void *, size_t) __POSIX_C_DEPRECATED(200112L);
         ^
/redacted/node_modules/@sentry/react-native/ios/RNSentry.m:129:43: error: bad receiver type 'void (*)(const void *, void *, size_t)' (aka 'void (*)(const void *, void *, unsigned long)')
        SentryClient.sharedClient.dist = [scope objectForKey:@"__sentry_dist"];
                                          ^~~~~
8 errors generated.


** BUILD FAILED *

This issue was introduced by eee7083.

@n4kz
Copy link

n4kz commented Sep 2, 2019

Looks like typo, scope should be renamed to extra

@HazAT
Copy link
Member

HazAT commented Sep 2, 2019

Sorry about that, fixed in 1.0.1 which should be released in <5min.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants