Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry-cli react-native xcode assumes presence of index.ios.js #624

Closed
2 of 5 tasks
ball-hayden opened this issue Jul 18, 2019 · 1 comment
Closed
2 of 5 tasks

sentry-cli react-native xcode assumes presence of index.ios.js #624

ball-hayden opened this issue Jul 18, 2019 · 1 comment

Comments

@ball-hayden
Copy link

ball-hayden commented Jul 18, 2019

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

v12.6.0
6.9.0
[email protected] /Users/hayden/development/PlayerData/app/mobile
├── @react-native-community/[email protected]
├── @react-native-community/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── UNMET PEER DEPENDENCY [email protected]
├── [email protected] -> /Users/hayden/development/PlayerData/app/edge-bluetooth-interface invalid
├── [email protected] -> /Users/hayden/development/PlayerData/app/edge-wifi-interface invalid
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected] -> /Users/hayden/development/PlayerData/app/playerdata-application invalid
├── [email protected]
├── UNMET PEER DEPENDENCY [email protected]
├── [email protected]
├── UNMET PEER DEPENDENCY [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

npm ERR! peer dep missing: [email protected], required by @date-io/[email protected]
npm ERR! peer dep missing: [email protected], required by [email protected]
npm ERR! peer dep missing: react-native@^0.41.2, required by [email protected]
npm ERR! peer dep missing: react-native@^0.41.2, required by [email protected]
npm ERR! invalid: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/edge-bluetooth-interface
npm ERR! missing: @babel/runtime@^7.3.1, required by [email protected]
npm ERR! missing: @types/react-native@^0.57.38, required by [email protected]
npm ERR! invalid: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/edge-wifi-interface
npm ERR! invalid: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application
npm ERR! peer dep missing: [email protected], required by @date-io/[email protected]
npm ERR! peer dep missing: [email protected], required by [email protected]
npm ERR! peer dep missing: react-native@^0.41.2, required by [email protected]
npm ERR! peer dep missing: react-native@^0.41.2, required by [email protected]
npm ERR! peer dep missing: babel-loader@^7.0.0 || ^8.0.0, required by @storybook/[email protected]
npm ERR! extraneous: @graphql-codegen/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@graphql-codegen/add
npm ERR! extraneous: @graphql-codegen/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@graphql-codegen/cli
npm ERR! extraneous: @graphql-codegen/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@graphql-codegen/fragment-matcher
npm ERR! extraneous: @graphql-codegen/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@graphql-codegen/typescript-operations
npm ERR! extraneous: @storybook/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@storybook/addon-actions
npm ERR! extraneous: @storybook/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@storybook/addon-knobs
npm ERR! extraneous: @storybook/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@storybook/react
npm ERR! extraneous: @storybook/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@storybook/react-native
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/classnames
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/enzyme
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/fetch-mock
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/graphql
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/humps
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/jest
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/js-base64
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/lodash
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/node-forge
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/query-string
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/react-native-permissions
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/react-native-vector-icons
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/react-router-dom
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/storybook__addon-actions
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/storybook__addon-knobs
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/storybook__react-native
npm ERR! extraneous: @types/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@types/uuid
npm ERR! extraneous: @typescript-eslint/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@typescript-eslint/eslint-plugin
npm ERR! extraneous: @typescript-eslint/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@typescript-eslint/parser
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link-schema
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/canvas
npm ERR! invalid: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/edge-bluetooth-interface
npm ERR! missing: @babel/runtime@^7.3.1, required by [email protected]
npm ERR! missing: @types/react-native@^0.57.38, required by [email protected]
npm ERR! invalid: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/edge-wifi-interface
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/enzyme
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/enzyme-adapter-react-16
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/enzyme-to-json
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint-config-airbnb
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint-config-prettier
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint-plugin-import
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint-plugin-jsx-a11y
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/eslint-plugin-react
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/fetch-mock
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/husky
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/jest
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/jest-junit
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/lint-staged
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/timekeeper
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/ts-jest
npm ERR! extraneous: @date-io/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@date-io/date-fns
npm ERR! extraneous: @material-ui/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@material-ui/core
npm ERR! extraneous: @material-ui/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@material-ui/icons
npm ERR! extraneous: @material-ui/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@material-ui/pickers
npm ERR! extraneous: @material-ui/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@material-ui/styles
npm ERR! extraneous: @react-native-community/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@react-native-community/async-storage
npm ERR! extraneous: @react-native-community/[email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/@react-native-community/netinfo
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-cache
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-cache-inmemory
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-cache-persist
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-client
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link-context
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link-http
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link-http-common
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-link-state
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/apollo-utilities
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/build-url
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/classnames
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/formik
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/graphql
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/graphql-anywhere
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/graphql-tag
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/history
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/humps
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/js-base64
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/lodash
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/mdi-material-ui
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/node-forge
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/path-to-regexp
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/query-string
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-apollo
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-art
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-dom
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-icons
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-email-link
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-fs
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-keychain
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-material-bottom-navigation
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-navigation
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-network-info
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-paper
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-permissions
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-svg
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-vector-icons
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-version-number
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-native-web
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-router
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/react-router-dom
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/ts-optchain
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/utility-types
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/uuid
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/zen-observable
npm ERR! extraneous: [email protected] /Users/hayden/development/PlayerData/app/mobile/node_modules/playerdata-application/node_modules/zen-observable-ts

Config:

Sentry.config('https://[email protected]/...').install()

I have following issue:

Running sentry-cli react-native xcode --allow-fetch tries to fetch from /index.ios.bundle.
Where a project has a common entry point (index.js), this file may not exist.

Steps to reproduce:

  • Create a react native project with a common index.js entrypoint for both Android and iOS.

Actual result:

  • An error is produced in the bundler logs, as sentry tries to fetch /index.ios.bundle

Expected result:

  • Sentry tries to fetch index.bundle.

The issue is caused by the hardcoded extension here:
https://github.com/getsentry/sentry-cli/blob/227668a9cb118f58342bec803b7eb62cb08a6e2c/src/commands/react_native_xcode.rs#L184-L191

@HazAT
Copy link
Member

HazAT commented Sep 4, 2019

I am closing all old issues, please if this is still a problem feel free to revive it.
Also, consider moving to our new SDK @sentry/react-native if it still happens there please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants