Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacktrace for native crash doesnt appear correctly #526

Closed
2 of 5 tasks
pvinis opened this issue Dec 21, 2018 · 5 comments
Closed
2 of 5 tasks

Stacktrace for native crash doesnt appear correctly #526

pvinis opened this issue Dec 21, 2018 · 5 comments

Comments

@pvinis
Copy link

pvinis commented Dec 21, 2018

OS:

  • Windows
  • MacOS
  • Linux

Platform:

  • iOS
  • Android

Output of node -v && npm -v && npm ls --prod --depth=0

% node -v && npm -v && npm ls --prod --depth=0
v10.13.0
6.4.1
[email protected] /Users/pvinis/Desktop/SentryBadStack
├── [email protected]
├── [email protected]
└── [email protected]

npm ERR! invalid: [email protected] /Users/pvinis/Desktop/SentryBadStack/node_modules/@sentry/wizard/node_modules/xcode
npm ERR! extraneous: [email protected] /Users/pvinis/Desktop/SentryBadStack/node_modules/@sentry/wizard/node_modules/uuid

Config:

Sentry.config('https://[email protected]/...').install()

I have following issue:
When a native crash happens, the stacktrace is all in one long line, and not formatted correctly.
It's not very useful, as we need to do the extra step of parsing it before we can see where the problem was.

Steps to reproduce:

  • yarn install
  • open ios/SentryBadStack.xcodeproj
  • switch to SentryBadStack Release scheme
  • yarn start
  • press play on xcode
  • tap CRASH JS button
  • see everything is nice
  • tap CRASH NATIVE button
  • see that the stacktrace looks weird, no formatting

repro repo: https://github.com/pvinis/SentryBadStack

Actual result:
crash-native

Expected result:
Something more like
this

@HazAT
Copy link
Member

HazAT commented Jan 9, 2019

Can you try to activate stacktrace merging with

Sentry.config('https://[email protected]/...', {
    deactivateStacktraceMerging: false
}).install()

We disabled it by default since it could have a performance impact on your app.

@HazAT HazAT self-assigned this Jan 9, 2019
@pvinis
Copy link
Author

pvinis commented Jan 9, 2019

I tried, same thing.

@pvinis
Copy link
Author

pvinis commented Jan 10, 2019

@HazAT Actually, I just checked again a bit more carefully. with deactivateStacktraceMerging: false, the native errors are not even reported! I was seeing the old ones before and thought they are the same. In my account, I deleted all the issues and tried again. Only js crashes are reported. That's even weirder. Can you reproduce it with my example repo?

@pvinis
Copy link
Author

pvinis commented Mar 20, 2019

UPDATE: This should be fixed on this PR and it will land on RN 0.60.0

@HazAT
Copy link
Member

HazAT commented Sep 4, 2019

I am closing all old issues, please if this is still a problem feel free to revive it.
Also, consider moving to our new SDK @sentry/react-native if it still happens there please open a new issue.

@HazAT HazAT closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants