-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getDefaultConfig from expo/metro-config compromise the sourceMappingURL and it has a wrong hash when exported for web platform #3663
Comments
Hi @claudioviola, |
Hey Krystof, Support received a request in Zendesk from a user with the same issue. Do you have an update for this problem? |
Hi @Fwang36, |
@krystofwoldrich is it resolved in v5.22.0? |
@amir-dropit No, 5.22.0 doesn't fix this particular issue. |
How is this not fixed yet? |
@krystofwoldrich can you please update on the manner? our source maps were not uploaded for 3 weeks because of this bug |
Hi, I'm sorry to hear that, I've opened a PR fixing this today. I'll also post here a workaround which you can use until the fix is released. |
Thanks a lot! 🙏 |
Until the fix is released, you can apply the changes from the fix PR using https://www.npmjs.com/package/patch-package |
|
This was fixed in expo/expo#30980 |
OS:
Platform:
Are you using Expo?
This is the configuration of my metro.config.js placed in the root folder project
I have the following issue:
Steps to reproduce:
2 files are created
AppEntry-9c58c4463ca3cfc79b6525f9cc37e942.js
AppEntry-9c58c4463ca3cfc79b6525f9cc37e942.js.map
Actual result:
Opening the first file for checking if the sourceMappingURL is correct
Actually the sourceMappingURL is wrong and it contains a different hash for the Javascript bundled file
//# sourceMappingURL=/_expo/static/js/web/AppEntry-c20e66115809b9d51b0088b809c85f32.js.map
Expected result:
Opening the first file for checking if the sourceMappingURL is correct
the sourceMappingURL should contains the correct hash and it should points to the correct file
//# sourceMappingURL=/_expo/static/js/web/AppEntry-9c58c4463ca3cfc79b6525f9cc37e942.js.map
if using in the metro.config.js
const { getDefaultConfig } = require('expo/metro-config');
the issue disappears and the sourceMappingURL contains the correct file
The text was updated successfully, but these errors were encountered: