Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version using sentry-android 7.2.0 #3570

Closed
pvegh opened this issue Jan 30, 2024 · 12 comments
Closed

Release version using sentry-android 7.2.0 #3570

pvegh opened this issue Jan 30, 2024 · 12 comments

Comments

@pvegh
Copy link
Contributor

pvegh commented Jan 30, 2024

Currently the newest version has a dependency on sentry-android 6.34.

In a hybrid project using sentry-android-gradle-plugin, which uses sentry-android 7.2.0, sentry-react-native isn't working with the forced newer version.

Please release all libraries with compatible dependencies together.

@bastiaanv
Copy link

Upvote!

@krystofwoldrich
Copy link
Member

@pvegh @bastiaanv Thank you for the message, we will release a new version of the RN SDK with the updated sentry-android soon.

For anyone running into issues here are steps on how to stay on v6 of sentry-android.

@pvegh
Copy link
Contributor Author

pvegh commented Feb 1, 2024

fresh released 5.18 still has the issue
+--- project :sentry_react-native
| | | | +--- io.sentry:sentry-android:6.34.0 -> 7.2.0

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 1, 2024
@krystofwoldrich
Copy link
Member

I will be part of the next release (likely 5.19.0).

@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Feb 5, 2024
@krystofwoldrich krystofwoldrich self-assigned this Feb 5, 2024
@krystofwoldrich krystofwoldrich moved this from Todo to Needs Review in Mobile & Cross Platform SDK Feb 5, 2024
@pvegh
Copy link
Contributor Author

pvegh commented Feb 8, 2024

Thanks.
But in that case it's going to be 7.3 vs 7.2 coming from https://github.com/getsentry/sentry-android-gradle-plugin/releases/tag/4.2.0

There should be a version with 7.2 to fix current compatibility problem before all libs are updated to 7.3 together.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Feb 8, 2024
@krystofwoldrich
Copy link
Member

@pvegh I'm not sure if I understand what would be the issue with 7.3. Could you describe an example?

https://github.com/getsentry/sentry-android-gradle-plugin ships with the latest sentry-android version at the moment of its release for convenience. But it's not limiting users from using different sentry-android versions they specify. You can use both older and newer versions of sentry-android with https://github.com/getsentry/sentry-android-gradle-plugin/releases/tag/4.2.0 with the auto-install disabled.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Feb 9, 2024
@getsantry getsantry bot moved this to Waiting for: Community in GitHub Issues with 👀 2 Feb 9, 2024
@krystofwoldrich krystofwoldrich moved this from Needs Review to Needs More Information in Mobile & Cross Platform SDK Feb 9, 2024
@getsantry
Copy link

getsantry bot commented Mar 2, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Mar 2, 2024
@pvegh
Copy link
Contributor Author

pvegh commented Mar 4, 2024

If sentry-android-gradle-plugin transitively uses 7.3 and sentry-react-native uses 7.2 it's a gradle dependency mismatch which will be solved by gradle, without guarantee that it will work perfectly.

Not sure how auto install works, just because I define a different version, is it guaranteed to function perfectly?

Thanks for the fix and release!

@getsantry getsantry bot moved this from Waiting for: Community to Waiting for: Product Owner in GitHub Issues with 👀 2 Mar 4, 2024
@getsantry getsantry bot removed the Stale label Mar 5, 2024
@krystofwoldrich
Copy link
Member

@pvegh Thank you for the details.

@markushi @romtsn Does the autoInstall flag solve the dependency mismatch?

@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Mar 6, 2024
@krystofwoldrich krystofwoldrich moved this from Needs More Information to Needs Investigation in Mobile & Cross Platform SDK Mar 6, 2024
@tobi512
Copy link

tobi512 commented Mar 8, 2024

Hey @krystofwoldrich , we use sentry-react-native in version 5.19.1 and native crash reports (from sentry-java loaded transitive via sentry-react-native) do report SDK version 6.30.0 in out backend, which seems wrong. I checked the source and sentry-react-native uses api 'io.sentry:sentry-android:7.x.0', not sure which version exactly but definitely a major 7, so something must be broken there.

Do you have any ideas? Thanks!

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Mar 8, 2024

@tobi512 Could it be crashes from older versions of your application?

When you clean build a release version of your app and cause a native crash on Android, what version gets reported?

Please feel free to report the details in a new issue.

@krystofwoldrich
Copy link
Member

Closing in favor of #3671 which solves the version mismatch.

@krystofwoldrich krystofwoldrich closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
@github-project-automation github-project-automation bot moved this from Needs Investigation to Done in Mobile & Cross Platform SDK Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

No branches or pull requests

4 participants