-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third party frames are not symbolicated #3546
Comments
Hi @pax-k, I see a small issue in the const { getSentryExpoConfig } = require('@sentry/react-native/metro');
const { mergeConfig } = require('metro-config');
const customConfig = require('./metro-custom.config.js');
const config = getSentryExpoConfig(__dirname);
const { resolver } = config;
config.resolver = {
...resolver,
sourceExts: [...resolver.sourceExts, 'cjs', 'mjs'],
};
module.exports = mergeConfig(config, customConfig); Could you share what is in For the Expo Updates (expo export), the command needs to emit the source maps: npx expo export --dump-sourcemaps
npx sentry-expo-upload-sourcemaps dist Are you using continuous code generation or do you maintain the native project your self? (If the latter can you share your Bundle React Native and Images build phase?) Let us know if this helps. |
Hey @krystofwoldrich ,
Sure, this is it:
Thanks! Actually I would never export the project manually if not necessary; I provided the manual step for brevity. But if necessary, I will implement it in our CI/CD.
I'm not using continuous code generation (or I don't think I'm doing it). The project is prebuilt/ejected (i have /ios and /android) and only maintain my native expo modules by upgrading their NPM deps by hand.
Can you please instruct me what do you mean exactly? I'm happy to provide anything useful. Thanks! |
Hey @krystofwoldrich, I have same issue with source maps, and I've been trying to run |
@krystofwoldrich @mrljsh how are you using the Sentry's React Native docs and the Expo docs both imply that it can be run with |
For me, npx command works but pnpx command returns 404 error. |
Worked it out. It's a package.json Seems to be working after yarn installing again. It's now running OK with |
I also have the same error that @pax-k has. I think the issue here is that the release and dist variables are not set. How can I set them? In both examples he has
|
@mrljsh Hi, thank you for the message, the script currently doesn't read |
here is the build phase script:
Seems like this script sources the |
@pax-k The build phase looks correct, also your original log from the build showed the source maps uploaded correctly. When you build the app could you bump the application version to something you haven't yet used so we can rule out that there is a collision of already uploaded source maps and the newly created ones? |
@krystofwoldrich we bump the app's version automatically, so it's safe to rule this out. Actually the problem is this:
Our 3rd party dependency we're interested in has it's own .map file. Also the .map produced by Tried adding this to metro.config.js:
But seems it doesn't affect the generated .map anyway |
@pax-k Thank you for the message. To avoid misunderstanding, do I understand correctly that only the third-party frames are not symbolicated, but application frames are? Is that the current issue? When you try to symbolicate the minified stack trace manual using https://reactnative.dev/docs/debugging-release-builds#using-metro-symbolicate |
Closing this due to inactivity. If this is still an issue feel free to comment here or open a new issue if the context changed. |
OS:
Platform:
SDK:
"@sentry/react-native": "5.16.0"
SDK version: 5.16.0
react-native
version: 0.73.2Are you using Expo?
Are you using sentry.io or on-premise?
If you are using sentry.io, please post a link to your issue so we can take a look:
[Link to issue]
Configuration:
(
@sentry/react-native
)(
app.config.js
)(`metro.config.js)
I have the following issue:
Steps to reproduce:
a) Run EAS Build => it should upload sourcemaps automatically. EAS Build XCode logs:
b) OR manual upload:
logs:
Contents of
dist/
:Actual result:
I cannot see the source code which triggered an error
Expected result:
I expect to see the source code which triggered an error
The text was updated successfully, but these errors were encountered: